New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed reading APP13 marker without Photoshop data #3771
Conversation
Thank you for sharing the solution |
At the moment, this is just a suggestion. It has not yet been accepted and become a part of Pillow. All things going well, it should be a part of Pillow 6.1.0 when it is released on July 1. If you would like to include this code in your installation before that, run this code to determine the path of your Pillow's JpegImagePlugin. >>> from PIL import JpegImagePlugin
>>> JpegImagePlugin
<module 'PIL.JpegImagePlugin' from '/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/site-packages/PIL/JpegImagePlugin.py'> Open that file path, and change the code as seen in the 'Files changed' tab of this PR. You only need to change that file, you don't need to change the test files. |
I tried this update, but still getting the same error:
|
Thanks for the traceback.
This shows that the code hasn't been updated, so you may want to try again. Alternatively, you could downgrade to Pillow 5.4.1 for the moment. |
When will we merge this fixed? |
It'll most likely be merged before the next release on 1st July. |
Is there any chance it may be merged earlier as a patch release? |
Patch releases are reserved for security, installation or critical bug fixes and I'm not sure this meets those criteria. |
Thanks, downgrading Pillow to version 5.4.1 solves my problem! |
This had been merged and will be in the next 6.1.0 release on 1st July. |
Changed the file accordingly and now the code runs. Thanks. |
Resolves #3769
https://dev.exiv2.org/projects/exiv2/wiki/The_Metadata_in_JPEG_files
The reported issue has found an image with 'Adobe_Photoshop2.5:'. This PR fixes the logic error that results in this issue with header strings that are not 'Photoshop 3.0\x00'. The test image is from #3772 (comment)